Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starlette: Replace _meter_provider by meter_provider on _instrument #3048

Merged
merged 3 commits into from
Nov 26, 2024
Merged

starlette: Replace _meter_provider by meter_provider on _instrument #3048

merged 3 commits into from
Nov 26, 2024

Conversation

Kludex
Copy link
Contributor

@Kludex Kludex commented Nov 26, 2024 •
edited
Loading

I found this while adding type hints on #3045.

@Kludex Kludex requested a review from a team as a code owner November 26, 2024 07:11
xrmx
xrmx approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@xrmx xrmx enabled auto-merge (squash) November 26, 2024 21:15
@xrmx xrmx merged commit 16ebf25 into open-telemetry:main Nov 26, 2024
566 checks passed
@emdneto emdneto mentioned this pull request Nov 28, 2024
Open
@Kludex Kludex deleted the replace-_meter_provider-by-meter_provider branch November 28, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdneto emdneto emdneto approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kludex @xrmx @emdneto